It is currently Mon Dec 11, 2017 4:20 pm

All times are UTC [ DST ]




Post new topic Reply to topic  [ 2 posts ] 
Author Message
 Post subject: [PATCH] passing of remote client ip as ipparam
PostPosted: Sat Jun 04, 2011 9:52 pm 

Joined: Sat Jun 04, 2011 9:18 am
Posts: 15
Hi All,

I've just been cooking up a patch to pass the connecting client's IP address as ipparam to pppd. The radius plugin for pppd passes the ipparam as the Calling-Station-Id tag, so what I would like to see on the radius side is something like this:

Calling-Station-Id = "172.24.5.10"

Which can then be logged as part of the radius session logs. One could even use it as part of the authentication/authorization phase on the radius side.

Patch available at https://bugs.gentoo.org/attachment.cgi?id=275845

As it stands it will apply cleanly after applying the optionsfile patch too. This is unfortunate but it touches many of the same code paths.

One thing that worries me ever so slightly is that there might be memory leaks based on the strdup() calls in ppp_unix_params_to_argv in plugins/ppp_unix.so - unless this is invoked after the daemon fork(2)s but before execve*(2).


Top
 Profile  
 
 Post subject: Re: [PATCH] passing of remote client ip as ipparam
PostPosted: Sun Jun 05, 2011 12:06 am 
Site Admin

Joined: Sun Jul 27, 2008 1:39 pm
Posts: 122
Another useful patch. Thanks!


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 2 posts ] 

All times are UTC [ DST ]


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group